Generate different base profile names for global and project configs #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
gejohnston
requested review from
zFernand0,
awharn,
t1m0thyj,
traeok,
ATorrise and
anaxceron
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2194 +/- ##
==========================================
+ Coverage 91.09% 91.11% +0.01%
==========================================
Files 632 632
Lines 18048 18077 +29
Branches 3856 3829 -27
==========================================
+ Hits 16440 16470 +30
+ Misses 1607 1606 -1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
anaxceron
approved these changes
Jul 11, 2024
ATorrise
approved these changes
Jul 15, 2024
zFernand0
approved these changes
Jul 15, 2024
Signed-off-by: Timothy Johnson <[email protected]>
|
|
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
Both the 'zowe config init' and 'zowe config auto-init' commands generate a base profile name of 'global_base' for a global config file and 'project_base' for a project config file.
How to Test
Run the commands and check out the name of the base profile in the resulting zowe.config.json file.
Review Checklist
I certify that I have:
Additional Comments